|
|
On Thu, Mar 19, 2009 at 10:15 PM, Danny Smith <dansmister@xxxxxxxxx> wrote:
> On Fri, Mar 20, 2009 at 5:00 AM, Kai Tietz <Kai.Tietz@xxxxxxxxxxxxx> wrote:
>> Dave Korn <dave.korn.cygwin@xxxxxxxxxxxxxx> wrote on 19.03.2009 16:59:47:
>>
>>> Kai Tietz wrote:
>>> > Hello,
>>> >
>>> > this patch fixes PR/39356 (
>>> > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39356)
>>>
>>> Hi Kai, just a minor nit:
>>>
>>> - .global ___chkstk
>>> - .global __alloca
>>> +.global ___gnu_chkstk
>>> +.global __alloca
>>> #ifndef _WIN64
>>> +.global ___chkstk
>>>
>>>
>>> Please retain the existing formatting convention for indenting
>> pseudo-ops.
>>> I'm guessing this is just accidental, since the earlier version of your
>> patch
>>> in the PR didn't do this.
>>>
>>> cheers,
>>> DaveK
>>>
>>
>> Thanks for noticing that, it was by accident (not by intention ;) ).
>> I've update the patch.
>>
>> Cheers,
>> Kai
>>
> This is OK by me, but please wait until 4.5, since this is not a regression.
> Danny
GCC 4.3 definitely worked as it should, without having a broken front
end. Why would you want to deliver 4.4 with a completely broken
driver for win64, when it worked earlier? The patch isn't tagged as a
regression, but it definitely is.
|
|