gcc-patches@gcc.gnu.org
[Top] [All Lists]

Re: [patch i386]: PR/39356 name collision of __chkstk

Subject: Re: [patch i386]: PR/39356 name collision of __chkstk
From: Kai Tietz
Date: Thu, 19 Mar 2009 17:00:53 +0100
Dave Korn <dave.korn.cygwin@xxxxxxxxxxxxxx> wrote on 19.03.2009 16:59:47:

> Kai Tietz wrote:
> > Hello,
> > 
> > this patch fixes PR/39356 (
> > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39356)
> 
>   Hi Kai, just a minor nit:
> 
> -   .global ___chkstk
> -   .global   __alloca
> +.global ___gnu_chkstk
> +.global   __alloca
>  #ifndef _WIN64
> +.global ___chkstk
> 
> 
>   Please retain the existing formatting convention for indenting 
pseudo-ops.
> I'm guessing this is just accidental, since the earlier version of your 
patch
> in the PR didn't do this.
> 
>     cheers,
>       DaveK
> 

Thanks for noticing that, it was by accident (not by intention ;) ).
I've update the patch.

Cheers,
Kai



|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.
<Prev in Thread] Current Thread [Next in Thread>