gcc-patches@gcc.gnu.org
[Top] [All Lists]

Re: mismatched parentheses in reload1.c

Subject: Re: mismatched parentheses in reload1.c
From: Jan Hubicka
Date: Thu, 24 Aug 2006 21:45:17 +0200
> 
>   else if (rld[r].out_reg == 0
>            && rld[r].in != 0
>            && ((REG_P (rld[r].in)
>                 && REGNO (rld[r].in) >= FIRST_PSEUDO_REGISTER
>                 && !REGNO_REG_SET_P (&reg_has_output_reload,
>                                      REGNO (rld[r].in))
>                || (REG_P (rld[r].in_reg)
>                    && !REGNO_REG_SET_P (&reg_has_output_reload,
>                                         REGNO (rld[r].in)))))
>            && ! reg_set_p (rld[r].reg_rtx, PATTERN (insn)))
> 
Sadly there is yet another typo in this particular change (I didn't
noticed even after proofreading the patch again after Paolo's original
mail).  It is causing the enable checking bootstrap fialures.
I've committed the attached patch and I do apologize^2 for this screwup.

Honza

Index: ChangeLog
===================================================================
*** ChangeLog   (revision 116383)
--- ChangeLog   (working copy)
***************
*** 1,5 ****
--- 1,9 ----
  2006-08-24  Jan Hubicka  <jh@xxxxxxx>
  
+       * reload1.c (emit_reload_insns): Fix yet another typo in my patch.
+ 
+ 2006-08-24  Jan Hubicka  <jh@xxxxxxx>
+ 
        PR debug/26881
        * cgraph.c: Fix comments.
        (cgraph_varpool_mark_needed_node): Mark only variables not already
Index: reload1.c
===================================================================
*** reload1.c   (revision 116383)
--- reload1.c   (working copy)
*************** emit_reload_insns (struct insn_chain *ch
*** 7394,7400 ****
                                                 REGNO (rld[r].in)))
                           || (REG_P (rld[r].in_reg)
                               && !REGNO_REG_SET_P (&reg_has_output_reload,
!                                                   REGNO (rld[r].in))))
                       && ! reg_set_p (rld[r].reg_rtx, PATTERN (insn)))
                {
                  int nregno;
--- 7394,7400 ----
                                                 REGNO (rld[r].in)))
                           || (REG_P (rld[r].in_reg)
                               && !REGNO_REG_SET_P (&reg_has_output_reload,
!                                                   REGNO (rld[r].in_reg))))
                       && ! reg_set_p (rld[r].reg_rtx, PATTERN (insn)))
                {
                  int nregno;

<Prev in Thread] Current Thread [Next in Thread>