gcc-patches@gcc.gnu.org
[Top] [All Lists]

Re: fixes for Darwin/x86

Subject: Re: fixes for Darwin/x86
From: Richard Henderson
Date: Thu, 1 Dec 2005 16:18:48 -0800
On Thu, Dec 01, 2005 at 04:03:51PM -0800, Stuart Hastings wrote:
> I'd be happy to remove this warning from the Darwin/PPC compiler;  
> would you approve such a patch?  (Darwin/PPC would pass 27 more C++  
> tests if we did.)

If distinguishing -fpic and -fPIC doesn't make sense for ppc-darwin
in the same way that it does for ppc-linux, I'd be happy to approve
a patch that makes -fpic and -fPIC mean the same thing for ppc-darwin.

> Should the regexp that matches the warning be removed from DejaGnu  
> (testsuite/lib/prune.exp)?

Probably.

> >Adjust the definition of USE_HIDDEN_LINKONCE instead.  I'm surprised
> >it isn't automatically happening...
> 
> O.K., but the Darwin assembler doesn't like the ".hidden" stuff  
> generated in ix86_file_end().  I'll need to hack up ix86_file_end()  
> to say  "if (USE_HIDDEN_LINKONCE && !TARGET_MACHO)".  :-P

So, how does the hidden support work in MACHO?  I know you've got it...

> I don't care where this stuff goes, but it has to go somewhere; it's  
> needed to fix a bunch of DejaGnu failures.  Would you prefer
> 
> A) pushing the LEA cruft into the builtin_setjmp_receiver pattern, or

This sounds best to me.


r~

<Prev in Thread] Current Thread [Next in Thread>