|
|
On Nov 30, 2005, at 10:32 PM, Hans-Peter Nilsson wrote:
On Wed, 30 Nov 2005, Stuart Hastings wrote:
C++ shows no regressions, but about 30 currently PASSing tests become
UNSUPPORTED; I think this is a DejaGnu issue. The patch adds a
Darwin/
x86-only warning that says "-fpic is not supported; -fPIC assumed",
just like Darwin/PPC, and the warning frightens DejaGnu into avoiding
g++.dg/debug/debug3.C (see the -fpic checking in testsuite/lib/
target-
supports.exp).
Um no, not a dejagnu issue. Why not silently equate -fpic with
-fPIC if you have no special size-or-time-optimization semantics
to put into -fpic? That's the difference between -fpic and -fPIC.
Darwin/PPC has the same -fpic/-fPIC semantics as Darwin/x86.
Emitting a warning is wrong.
Great, let's fix Darwin/PPC, because it's also wrong. As I noted in
the comments, Darwin/PPC has the same 27 UNSUPPORTED tests.
If the warning is wrong, should we remove the regexp that matches
such warnings from testsuite/lib/prune.exp ?
If I offered a patch to remove the warning from Darwin/PPC, and the
regexp from DejaGnu, would you approve it?
stuart
|
|