gcc-patches@gcc.gnu.org
[Top] [All Lists]

Re: Paolo cross RTEMS build patch review

Subject: Re: Paolo cross RTEMS build patch review
From: Paolo Bonzini
Date: Mon, 05 Dec 2005 18:17:20 +0100

Hi Mark, Paolo posted his patch to fix the cross RTEMS build process on
november 19th, after two pings and 11 days it hasn't been reviewed.

Patch URL:
http://gcc.gnu.org/ml/gcc-patches/2005-11/msg01404.html

On November 21st I wrote:

I will review the patch, if it comes to that, but I'd much prefer that a
build system maintainer take a look.  If that doesn't happen, within a
few days, let me know.

It's certainly been a few days.  However, I now realize that this is not
only code I don't know very well -- it may not even be code I have write
privileges for, as its shared with src.

I've applied the patch to gcc and src, after testing:
- a native i686-pc-linux-gnu bootstrap (all languages including Ada), which was completed and regtested successfully - a native i686-pc-linux-gnu toplevel bootstrap (all languages including Ada), which was completed and regtested successfully - an i686-pc-linux-gnu -> arm-none-elf (all languages excluding Ada) with a unified tree, which was ok - an i686-pc-linux-gnu -> arm-rtems4.7 cross with a unified tree, C/Ada, which ICEd while building libada (but did not reach that place without this patch and http://gcc.gnu.org/ml/gcc-patches/2005-12/msg00342.html) - an i686-pc-linux-gnu -> sparc-rtems4.7 cross with a unified tree, C/Ada, which built libada successfully (gnattools failed because I only had GNAT 4.0 installed, but building a cross Ada compiler requires a same-version GNAT to be present). - a binutils-only tree, which succeeded (but anyway binutils has no target libraries, so it should not be touched by this patch).

A few weeks ago, I also built a cross for host=target=arm-none-elf, build=i686-pc-linux-gnu with this patch.

I'll commit the patch to 4.1 patch in a few days (most likely Monday 12th, actually).

Paolo

<Prev in Thread] Current Thread [Next in Thread>