gcc-patches@gcc.gnu.org
[Top] [All Lists]

Re: [PowerPC] Correct testsuite target matching]

Subject: Re: [PowerPC] Correct testsuite target matching]
From: Janis Johnson
Date: Mon, 12 Dec 2005 18:00:34 -0800
On Tue, Dec 13, 2005 at 09:51:37AM +1030, Alan Modra wrote:
> A number of tests in the gcc testsuite are only suitable for powerpc
> SYSV4 ABI, and others only run properly on powerpc 64-bit.  The
> testsuite selects which ABI by comparing the target to powerpc-*-* or
> powerpc64-*-*, but we can build powerpc-linux and powerpc64-linux biarch
> compilers, and both of these targets can choose whether they are 32- or
> 64-bit by default.  The right target check is powerpc*-*-* along with
> ilp32 or lp64.  OK mainline?

I prefer:

   /* { dg-do compile { target { powerpc*-*-* && lp64 } } } */

to:

   /* { dg-do compile { target powerpc*-*-* } } */
   /* { dg-require-effective-target lp64 } */

but it's not a strong preference, so OK for mainline.  It's also OK
for release branches for which the change doesn't cause the test to
start failing.

Janis

<Prev in Thread] Current Thread [Next in Thread>