|
|
>
> Mark Mitchell wrote:
> > Joseph S. Myers wrote:
> >> This patch fixes bug 17964, a regression in preprocessor diagnostics
> >> for C++ caused by lexing up front but deferring string interpretation
> >> (which depends on the parse context) until later, so the
> >> preprocessor's notion of source location does not relate to the actual
> >> source location at that point.
> > I think this is fine.
>
> I'm afraid this breaks the bootstrap with GCC 2.95, and perhaps early
> versions of GCC 3.x as well:
>
> In file included from /gcc/trunk/libcpp/charset.c:23:
> /gcc/trunk/libcpp/include/cpplib.h:477: argument format specified
> for non-function `error'
>
> The patch below fixes this. Bootstrapped on i386-unknown-freebsd4.10.
>
> Okay for HEAD and the 4.0 branch?
>
> Gerald
>
> 2005-11-13 Gerald Pfeifer <gerald@xxxxxxxxxxx>
>
> * include/cpplib.h (struct cpp_callbacks): Remove
> ATTRIBUTE_PRINTF(3,0) from error.
What about adding a new macro so the attribute can be added to function types.
-- Pinski
|
|