gcc-patches@gcc.gnu.org
[Top] [All Lists]

Re: Patch for bug c++/17964 (cpp error locations for C++)

Subject: Re: Patch for bug c++/17964 cpp error locations for C++
From: Ian Lance Taylor
Date: 13 Nov 2005 15:26:01 -0800
Gerald Pfeifer <gerald@xxxxxxxxxxx> writes:

> Like so?  This has passed a full bootstrap on i386-unknown-freebsd4.11
> using the system compiler which is based on GCC 2.95.4.
> 
> (Joseph, indeed with my original patch I had the problem you hinted at;
> something went wrong with my testing yesterday.)
> 
> Gerald
> 
> 2005-11-13  Gerald Pfeifer  <gerald@xxxxxxxxxxx>
>             Ian Lance Taylor  <ian@xxxxxxxx>
> 
> Index: libcpp/include/cpplib.h
> ===================================================================
> --- libcpp/include/cpplib.h   (revision 106864)
> +++ libcpp/include/cpplib.h   (working copy)
> @@ -474,7 +474,7 @@
>    /* Called to emit a diagnostic if client_diagnostic option is true.
>       This callback receives the translated message.  */
>    void (*error) (cpp_reader *, int, const char *, va_list *)
> -       ATTRIBUTE_PRINTF(3,0);
> +       ATTRIBUTE_FPTR_PRINTF(3,0);
>  };
>  
>  /* Chain of directories to look for include files in.  */

I can't approve patches to libcpp, but this looks pretty much obvious
to me.

Ian

<Prev in Thread] Current Thread [Next in Thread>