gcc-patches@gcc.gnu.org
[Top] [All Lists]

Re: [patch] Add basic support for arm-none-linux-gnueabi.

Subject: Re: [patch] Add basic support for arm-none-linux-gnueabi.
From: Daniel Jacobowitz
Date: Wed, 24 Aug 2005 09:28:04 -0400
On Sat, Aug 20, 2005 at 10:27:51AM -0700, Kazu Hirata wrote:
> Hi,
> 
> Attached is a patch to add basic support for arm-none-linux-gnueabi.
> 
> The gcc portion is taken from
> 
>   http://gcc.gnu.org/ml/gcc-patches/2004-11/msg01636.html
> 
> I had to make a minor modification to libcpp's configuration bits.
> Specifically, I needed need_64bit_hwint=yes so that HOST_WIDE_INT
> would have the same size in both libcpp and gcc.
> 
> Built arm-none-linux-gnueabi.  OK to apply?

Have you diffed the affected files between this patch and
csl-arm-branch?  If not, please do that.  The patch is certainly not OK
as is; for instance I see the ABI fix for WCHAR_TYPE is missing. 
Searching ChangeLog.csl-arm for "linux", I see about four other
relevant patches.

Fixing the missing space Joseph pointed out on csl-arm-branch would be
nice if you've got a chance.

You didn't mention if you'd run the testsuite on this.  If so, you
might want to also try running the compat testsuite against a
csl-arm-branch compiler.

> p.s.
> By the way, is anybody trying to cleanup need_64bit_hwint?  It's less
> than ideal to have it in both libcpp and gcc and maintain it manually.
> (But then I don't know if it's worth messing with the top-level
> configure bits just for libcpp and gcc.)

IMO we want to get rid of H_W_I from that interface, but I'm not sure
how to do it without slowing down 32-bit HWI targets...


-- 
Daniel Jacobowitz
CodeSourcery, LLC

<Prev in Thread] Current Thread [Next in Thread>