[email protected]
[Top] [All Lists]

Re: Request for review: stripesnoop

Subject: Re: Request for review: stripesnoop
From: Ralf Ertzinger
Date: Thu, 4 Aug 2005 23:25:51 +0200

Chris Grau <[email protected]> wrote:

> Bad:
> - -devel requires %{name}-%{version}-%{release}

Is it bad that it requires it or that it does not require it?

> The compiler warnings look harmless to me.  It's just fgets() and the
> string buffer appears to be handled fine.  It could be worse, the author
> could have used gets(), but this isn't a code review.

This means that the author assumes that the fgets always succeeds, which
is usually not a good idea.

arachnoleptic fit, n:
        The frantic dance performed just after you've accidentally
        walked through a spider web.

fedora-extras-list mailing list
[email protected]

<Prev in Thread] Current Thread [Next in Thread>