|
|
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: xscorch - A Scorched Earth clone
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166626
j.w.r.degoede@xxxxxx changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From j.w.r.degoede@xxxxxx 2005-08-26 05:26 EST
-------
One more note about my specfile changes I also added:
%dir %{_datadir}/xscorch
But it seems that:
%{_datadir}/xscorch/ does that automaticly, so that should be removed again.
Also the changelog needs updating for the made changes.
Reviewing:
-rpmlint: Error while reading /home/hans/xscorch.spec
It gives the same error while reading other specs appearantly rpmlint
is broken, see bug 166826. skipping this step.
-package name + specfile name: ok
-packaging guidelines: ok
-license + license tag + license in %doc: ok
-spec file readable: ok
-source matches upstream: ok
-long list off small nitpicks: all ok
So in short:
-remove the %dir %{_datadir}/xscorch I added
-write a changelog entry
And its approved.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
--
fedora-extras-list mailing list
fedora-extras-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-extras-list
|
|