Re: libc warnings/fix

[christos@xxxxxxxxxx (Christos Zoulas)]

On Jul 25, 12:31pm, andy.shevchenko@xxxxxxxxx ("Andy Shevchenko") wrote:
-- Subject: Re: libc warnings/fix

| On Thu, Jul 24, 2008 at 11:41 PM, David Laight <david@xxxxxxxxx> wrote:
| >> >[1]: http://koowaldah.org/people/ash/netbsd/fix-libc-warnings.patch
| > Save us by inlining patches that are that short...
| I don't understand your optimism.
| 
| 1.
|   some_type *ci;
|   ...
|   ret = get_shared(&ci, ...);
| 
| How could you guess about usage of the **ci?
| Indeed get_shared() doesn't care about contains of **rci in some branches.

Then it returns non zero, and the calling code does not use rci.

| 2. The same behaviour for lookup_mapper_entry() and **variable.

Again same I guess.

| 3. Probably compilator regression is occur.
| 
| I think the gcc is right in 1. and 2. predictions.

I will apply the patches.

christos