fa.netbsd.tech.kern
[Top] [All Lists]

Re: libc warnings/fix

Subject: Re: libc warnings/fix
From: "Andy Shevchenko" <andy.shevchenko@xxxxxxxxx>
Date: Fri, 25 Jul 2008 09:31:44 UTC
Newsgroups: fa.netbsd.tech.kern

On Thu, Jul 24, 2008 at 11:41 PM, David Laight <david@xxxxxxxxx> wrote:
>> >[1]: http://koowaldah.org/people/ash/netbsd/fix-libc-warnings.patch
> Save us by inlining patches that are that short...
I don't understand your optimism.

1.
  some_type *ci;
  ...
  ret = get_shared(&ci, ...);

How could you guess about usage of the **ci?
Indeed get_shared() doesn't care about contains of **rci in some branches.

2. The same behaviour for lookup_mapper_entry() and **variable.
3. Probably compilator regression is occur.

I think the gcc is right in 1. and 2. predictions.

-- 
With Best Regards,
Andy Shevchenko

<Prev in Thread] Current Thread [Next in Thread>