fa.netbsd.tech.kern
[Top] [All Lists]

Re: libc warnings/fix

Subject: Re: libc warnings/fix
From: David Laight <david@xxxxxxxxx>
Date: Thu, 24 Jul 2008 20:47:10 UTC
Newsgroups: fa.netbsd.tech.kern

On Thu, Jul 24, 2008 at 08:24:47PM +0000, Christos Zoulas wrote:
> In article <20080724074745.GI22423@xxxxxxxxxxxxx>,
> Alexander Shishkin  <alexander.shishkin@xxxxxxxxxx> wrote:
> >Hi,
> >
> >I have one more patch [1] to fix three "may be used uninitialized in this
> >function" warnings emitted by newer gcc. All three are unlikely to cause
> >any problems [obviously], but are perfectly valid from compiler's
> >standpoint.
> >
> >[1]: http://koowaldah.org/people/ash/netbsd/fix-libc-warnings.patch

Save us by inlining patches that are that short...

> Why? The first two seem like compiler regressions and the compiler should
> be able to figure out. The third is more difficult for the compiler to figure
> out, so it is acceptable.

I guess the first is because the compiler has detected that 'get_shared'
doesn't set '*rci' in all paths.

Similarly for '*variable' in lookup_mapper_entry.

        David

-- 
David Laight: david@xxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>