[email protected]
[Top] [All Lists]

Bug#444113: marked as forwarded (gpscorrelate: negative timezone adjustm

Subject: Bug#444113: marked as forwarded gpscorrelate: negative timezone adjustments with minutes are not handled correctly
From: Debian Bug Tracking System
Date: Wed, 26 Sep 2007 08:54:03 +0000
Your message dated Wed, 26 Sep 2007 10:50:30 +0200
with message-id <[email protected]>
has caused the Debian Bug report #444113,
regarding gpscorrelate: negative timezone adjustments with minutes are not 
handled correctly
to be marked as having been forwarded to the upstream software
author(s) Daniel Foote <[email protected]>.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Subject: : Bug#444113: gpscorrelate: negative timezone adjustments with minutes are not handled correctly]
From: Stefano Zacchiroli
Date: Wed, 26 Sep 2007 10:50:30 +0200
Hi Daniel,
  can you have a look at the attached patch?

TIA,
Cheers.

----- Forwarded message from Marc Horowitz <[email protected]> -----

Date: Wed, 26 Sep 2007 03:12:29 -0400
From: Marc Horowitz <[email protected]>
To: Debian Bug Tracking System <[email protected]>
Subject: Bug#444113: gpscorrelate: negative timezone adjustments with minutes 
are not handled correctly

Package: gpscorrelate
Version: 1.5-1+b2
Severity: important
Tags: patch


Negative timezone adjustments with minutes are not handled correctly.
The minute piece should have the same sign as the hour piece, but it
is always positive due to the way it is parsed.

The attached patch should fix the problem for both the cli and gui

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.16-2-k7
Locale: LANG=en_US.ISO8859-1, LC_CTYPE=en_US.ISO8859-1 (charmap=ISO-8859-1)

Versions of packages gpscorrelate depends on:
ii  libc6                      2.6.1-1+b1    GNU C Library: Shared libraries
ii  libexiv2-0                 0.15-1        EXIF/IPTC metadata manipulation li
ii  libgcc1                    1:4.2.1-4     GCC support library
ii  libstdc++6                 4.2.1-4       The GNU Standard C++ Library v3
ii  libxml2                    2.6.29.dfsg-1 GNOME XML library

gpscorrelate recommends no packages.

-- no debconf information

--- orig/gpscorrelate-1.5/main-command.c        2006-09-02 05:27:00.000000000 
-0400
+++ gpscorrelate-1.5/main-command.c     2007-09-26 03:02:44.000000000 -0400
@@ -307,6 +307,8 @@
                {
                        /* Found colon. Split into two. */
                        sscanf(TimeAdjustment, "%d:%d", &TimeZoneHours, 
&TimeZoneMins);
+                       if (TimeZoneHours < 0)
+                           TimeZoneMins *= -1;
                } else {
                        /* No colon. Just parse. */
                        TimeZoneHours = atoi(TimeAdjustment);
--- orig/gpscorrelate-1.5/gui.c 2006-09-02 05:27:00.000000000 -0400
+++ gpscorrelate-1.5/gui.c      2007-09-26 03:03:25.000000000 -0400
@@ -922,6 +922,8 @@
        {
                /* Found colon. Split into two. */
                sscanf(TZString, "%d:%d", &Options.TimeZoneHours, 
&Options.TimeZoneMins);
+               if (Options.TimeZoneHours < 0)
+                   Options.TimeZoneMins *= -1;
        } else {
                /* No colon. Just parse. */
                Options.TimeZoneHours = atoi(TZString);


----- End forwarded message -----

-- 
Stefano Zacchiroli -*- PhD in Computer Science ............... now what?
[email protected]{cs.unibo.it,debian.org,bononia.it} -%- http://www.bononia.it/zack/
(15:56:48)  Zack: e la demo dema ?    /\    All one has to do is hit the
(15:57:15)  Bac: no, la demo scema    \/    right keys at the right time

--- End Message ---
<Prev in Thread] Current Thread [Next in Thread>
  • Bug#444113: marked as forwarded (gpscorrelate: negative timezone adjustments with minutes are not handled correctly), Debian Bug Tracking System <=