[email protected]
[Top] [All Lists]

Bug#283373: marked as forwarded (Patcher doesn't handle $EDITOR/$VISUAL

Subject: Bug#283373: marked as forwarded Patcher doesn't handle $EDITOR/$VISUAL correctly
From: Debian Bug Tracking System
Date: Wed, 23 Feb 2005 13:18:17 -0800
Your message dated Wed, 23 Feb 2005 16:17:54 -0500
with message-id <[email protected]>
has caused the Debian Bug report #283373,
regarding Patcher doesn't handle $EDITOR/$VISUAL correctly
to be marked as having been forwarded to the upstream software
author(s) Holger Schurig <[email protected]>.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

---------------------------------------
Received: (at 283373-forwarded) by bugs.debian.org; 23 Feb 2005 21:13:28 +0000
>From [email protected] Wed Feb 23 13:13:28 2005
Return-path: <[email protected]>
Received: from hostinworld8.com (ns.hostinworld8.com) [66.227.36.185] 
        by spohr.debian.org with smtp (Exim 3.35 1 (Debian))
        id 1D43p2-0007mH-00; Wed, 23 Feb 2005 13:13:28 -0800
Received: (qmail 12293 invoked from network); 23 Feb 2005 21:08:44 -0000
Received: from softdnserror (HELO ?192.168.0.4?) (63.245.86.121)
  by hostinworld8.com with SMTP; 23 Feb 2005 21:08:44 -0000
Subject: Fwd: #283373: Patcher doesn't handle $EDITOR/$VISUAL correctly
From: "Alejandro Rios P." <[email protected]>
To: Holger Schurig <[email protected]>
Cc: [email protected],  [email protected]
Content-Type: multipart/signed; micalg=pgp-sha1; 
protocol="application/pgp-signature"; boundary="=-RBoCorX3Pc06Pw29kerL"
Date: Wed, 23 Feb 2005 16:17:54 -0500
Message-Id: <[email protected]>
Mime-Version: 1.0
X-Mailer: Evolution 2.0.3 
Delivered-To: [email protected]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 


--=-RBoCorX3Pc06Pw29kerL
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi Schurig,

I'm resending this bug against patcher in order to tag the bug as forwarded=
.=20

Right now I'm very busy working at my graduation project, but thanks to it =
I've learned the perl I need to help closing patcher's bugs, so in about a =
moth or so I'll be able to deal with them.

Thanks for your understanding.

Alejandro.

P.S.: Please preserve the CC to [email protected] when you r=
eply, so that the bug tracking system will file the reply with the original=
 report.

----
Date: Sun, 28 Nov 2004 17:26:25 +0100
From: [email protected]
To: [email protected]
Subject: Patcher doesn't handle $EDITOR/$VISUAL correctly

Package: patcher
Version: 0.0.20040521-1
Tags: patch

Patcher doesn't handle the case when $EDITOR contains a command plus
default arguments correctly:

$ echo $EDITOR
joe -nobackups
$ patcher -n foo foo
NOTE: editing file foo
Can't exec "joe -nobackups": No such file or directory at /usr/bin/patcher
line 752.
$ EDITOR=3Djoe
$ patcher -n foo foo
NOTE: editing file foo
Processing '/home/mb/.joerc'...done
[...]

To the best of my knowledge, putting default arguments into $EDITOR is
legal. At least I haven't seen another application having problems with
this so far.

The easiest solution probably would be to simply call "sensible-editor"
(which would have the additional bonus of also respecting $VISUAL):

--- patcher.orig        Sun Nov 28 17:19:52 2004
+++ patcher     Sun Nov 28 17:20:30 2004
@@ -747,13 +747,7 @@
=20
        return if $do_add;
=20
-       if ($ENV{EDITOR}) {
-               print "NOTE: editing file $fname\n";
-               system($ENV{EDITOR}, $fname);
-       } else {
-               print "\$EDITOR to $fname missing\n";
-               system("vi " . $fname);
-       }
+       system("sensible-editor " . $fname);
 }
=20


--=20
Alejandro R=EDos Pe=F1a.
--
Grupo GNU/Linux Universidad del Cauca.
Comunidad Debian-Colombia.
Avatar Ltda.

--=-RBoCorX3Pc06Pw29kerL
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada
        digitalmente

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQBCHPMCoby7LzBs3/MRAqPlAJ0bkKhVzJS9lgP0PeJ/OTTl45r69wCfeArp
JowG0zi4UyICmPfIht0GiaY=
=3miy
-----END PGP SIGNATURE-----

--=-RBoCorX3Pc06Pw29kerL--


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

<Prev in Thread] Current Thread [Next in Thread>
  • Bug#283373: marked as forwarded (Patcher doesn't handle $EDITOR/$VISUAL correctly), Debian Bug Tracking System <=