|
|
> -----Original Message-----
> From: Felipe Leme [mailto:maven@xxxxxxxxxxxx]
> Sent: lundi 8 novembre 2004 21:10
> To: Cactus Developers List
> Subject: RE: Cactus-132 bug (+ some other comments on test06)
>
>
> > Ok, thanks. What I don't understand is what is this Resources.java file
> in
> > test06?
>
> It's not test06, it's testIncludedResources :-)
Hehe... :-)
>
> Felipe, any idea? It's not commented and its use is not obvious to
> > me. The fact that there is no sourceDirectory defined and that the test
> > still passes seem to indicate it's not required and it should be
> deleted. Is
> > this true? ;-)
>
> Yes, I guess it's not necessary.
Ok, I have removed it. I haven't read yet the other tests so I don't know if
this pattern repeats or not.
>
> > WAR are there!). Would it be possible to comment all files that are
> > committed so that we have at least the same level of comment quality
> than
> > what exists in the rest of Cactus? We don't need to overdo it, but
> anywhere
> > where it's not obvious would be much welcome... :-)
>
> I do commit every file, but sometimes I use the same comment for a
> recursive commit (that's what happened in this case). So, I think we
> should either document the class itself or, better yet, document what the
> test case does in the <description> (at the POM level).
Oops, sorry. I was talking about java or xml comments in the file itself.
>
> > This seems completely useless to me and we've paid great attention in
> all
> > the rest of the Cactus code not to have this (because it's not useful
> IMO).
> > Let me know if there's a reason I don't see! :-)
>
> Ok.
Removed for this one + added javadoc for the class + added @version tag.
Could you please check if this pattern repeats in the other tests you have
committed?
[snip]
> Agreed - convention is important. BTW, what about defining a default
> package for testcase classes (for instance,
> org.apache.cactus.testcases.maven)?
There is one already. All code must go inside:
org.apache.cactus.[module type/name]
For example, for the Integration/Ant module, it is:
org.apache.cactus.integration.ant
For samples/servlet, it is: org.apache.cactus.samples.servlet
Thus for the one you mention, it is: org.apache.cactus.integration.maven.*
For unit tests we use the same package as the class they are testing but
here it is integration/functional tests so feel free to add a "test" (or
other) package if you wish (although I don't think it is really necessary):
org.apache.cactus.integration.maven.[someothername].*
Thanks
-Vincent
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@xxxxxxxxxxxxxxxxxx
For additional commands, e-mail: cactus-dev-help@xxxxxxxxxxxxxxxxxx
|
|